Project

General

Profile

Actions

Cleanup #38003

closed

mgr/dashboard: Avoid merge conflicts in messages.xlf by auto-generating it at build time?

Added by Lenz Grimmer over 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
-
Category:
i18n
Target version:
% Done:

0%

Tags:
Backport:
nautilus
Reviewed:

Description

Currently, the file ./src/pybind/mgr/dashboard/frontend/src/locale/messages.xlf needs to be updated by running "npm run i18n" every time when changes to the UI have been made that affect translatable strings. The modified messages.xlf file then needs to be commited and is part of the changeset. This approach has several issues:

  • As this file potentially gets modified by many pull requests, it becomes a "hot spot", requiring lots of rebasing and resolving of conflicts
  • Including the messages.xlf file in the same commit as other changes makes it more difficult to back-port such a change to older releases, where the messages.xlf might differ significantly

Would it make sense to treat this file as an asset that gets generated at build time instead, taking it out of git revision control?


Related issues 2 (0 open2 closed)

Has duplicate Dashboard - Cleanup #39627: mgr/dashboard: Remove messages.xlf fileDuplicate

Actions
Copied to Dashboard - Backport #39658: nautilus: mgr/dashboard: Avoid merge conflicts in messages.xlf by auto-generating it at build time?ResolvedTiago MeloActions
Actions

Also available in: Atom PDF