Project

General

Profile

Actions

Feature #65747

open

common/admin_socket: support saving json output to a file local to the daemon

Added by Patrick Donnelly 16 days ago. Updated 16 days ago.

Status:
In Progress
Priority:
Normal
Category:
common
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
squid,reef,quincy
Reviewed:
Affected Versions:
Pull request ID:

Description

The ceph tell mds.X cache dump and ceph tell mds.X ops commands have a useful --path argument that directs the daemon to save the dump of the output to a file local the daemon. This has several advantages:

  • We don't need to construct the JSON output in memory, which may be many gigabytes.
  • Streaming writes to a local file is significantly faster than sending the data over the ceph messenger.
  • The command spends as little time as possible holding relevant locks.

However, only some commands support this and we could make it generic to the admin socket interface. So, add a generic --output-file argument to achieve this.

The main concern with this is security (telling the daemon to write to arbitrary files) but this is gated by the session caps which require "allow_all" and that's typically only valid for the client.admin.

Actions #1

Updated by Patrick Donnelly 16 days ago

  • Status changed from New to In Progress
  • Pull request ID set to 57215
Actions

Also available in: Atom PDF