Project

General

Profile

Actions

Bug #61879

closed

mds: linkmerge assert check is incorrect in rename codepath

Added by Kotresh Hiremath Ravishankar 11 months ago. Updated 6 months ago.

Status:
Resolved
Priority:
Normal
Category:
Correctness/Safety
Target version:
% Done:

100%

Source:
Tags:
backport_processed
Backport:
reef,quincy,pacific
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
MDS
Labels (FS):
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

Let's say there is a hardlink created as below.

touch file1
ln file1 hl_file1

In this case file1 holds the primary inode and hl_file holds the remote inode (small struct, holds info about primary).
Now, if file1 is deleted first, a stray reintegration (the deleted primary straydn is merged with secondary inode) could happen
which links the primary inode to the hl_file1 which is called linkmerge. So in the linkmerge case, the srcdnl is primary straydn
and the destdnl is the remote.


Related issues 3 (0 open3 closed)

Copied to CephFS - Backport #62240: reef: mds: linkmerge assert check is incorrect in rename codepathResolvedKotresh Hiremath RavishankarActions
Copied to CephFS - Backport #62241: quincy: mds: linkmerge assert check is incorrect in rename codepathResolvedKotresh Hiremath RavishankarActions
Copied to CephFS - Backport #62242: pacific: mds: linkmerge assert check is incorrect in rename codepathResolvedKotresh Hiremath RavishankarActions
Actions #1

Updated by Kotresh Hiremath Ravishankar 11 months ago

  • Category set to Correctness/Safety
  • Component(FS) MDS added
Actions #2

Updated by Kotresh Hiremath Ravishankar 11 months ago

  • Pull request ID set to 51934
Actions #3

Updated by Kotresh Hiremath Ravishankar 11 months ago

  • Status changed from New to Fix Under Review
  • Assignee set to Kotresh Hiremath Ravishankar
Actions #4

Updated by Venky Shankar 10 months ago

  • Status changed from Fix Under Review to Pending Backport
  • Target version set to v19.0.0
  • Backport set to reef,quincy,pacific
Actions #5

Updated by Backport Bot 10 months ago

  • Copied to Backport #62240: reef: mds: linkmerge assert check is incorrect in rename codepath added
Actions #6

Updated by Backport Bot 10 months ago

  • Copied to Backport #62241: quincy: mds: linkmerge assert check is incorrect in rename codepath added
Actions #7

Updated by Backport Bot 10 months ago

  • Copied to Backport #62242: pacific: mds: linkmerge assert check is incorrect in rename codepath added
Actions #8

Updated by Backport Bot 10 months ago

  • Tags set to backport_processed
Actions #9

Updated by Konstantin Shalygin 6 months ago

  • Status changed from Pending Backport to Resolved
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF