Project

General

Profile

Actions

Bug #43249

closed

cephfs-shell: exit failure when non-interactive command fails

Added by Patrick Donnelly over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
High
Assignee:
Category:
-
Target version:
% Done:

0%

Source:
Development
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Component(FS):
cephfs-shell
Labels (FS):
task(easy)
Pull request ID:
Crash signature (v1):
Crash signature (v2):

Description

If a one-shot command fails, the cephfs-shell should exit with a non-zero status:

CephFS:~/>>> pdonnell@senta03 ~/ceph/build$ cephfs-shell mkdir /a/b
error in mkdir /a/b: No such file or directory [Errno 2]
CephFS:~/>>> pdonnell@senta03 ~/ceph/build$ echo $?
0

(#43248 deals with the shell dropping into interactive mode after executing the command.)

The shell should exit with 1 if the command fails.


Related issues 1 (0 open1 closed)

Related to CephFS - Bug #43248: cephfs-shell: do not drop into shell after running command-line commandResolvedRishabh Dave

Actions
Actions #1

Updated by Patrick Donnelly over 4 years ago

  • Related to Bug #43248: cephfs-shell: do not drop into shell after running command-line command added
Actions #2

Updated by Rishabh Dave over 4 years ago

  • Status changed from New to In Progress
Actions #3

Updated by Rishabh Dave over 4 years ago

  • Status changed from In Progress to Fix Under Review
Actions #4

Updated by Patrick Donnelly over 4 years ago

  • Pull request ID set to 32213
Actions #5

Updated by Patrick Donnelly over 4 years ago

  • Status changed from Fix Under Review to Resolved
Actions

Also available in: Atom PDF