Project

General

Profile

Actions
Copy link

Bug #40399

closed

mgr/dashboard: Reduce code duplication through TableActionComponent Unit Tests

Added by Patrick Seidensal almost 5 years ago. Updated about 3 years ago.

Status:
Resolved
Priority:
Normal
Assignee:
Patrick Seidensal
Category:
-
Target version:
Ceph - v15.0.0
% Done:

90%

Source:
Tags:
Backport:
Regression:
No
Severity:
3 - minor
Reviewed:
Affected Versions:
ceph-qa-suite:
Pull request ID:
28633
Crash signature (v1):
Crash signature (v2):

Description

The test code for TableActionsComponent is reused at least 7 times across the modules which implement it. This results in duplicated code. With a refactoring, we could save at least 1000 lines of code in frontend unit tests.

Actions
Copy link
 #1

Updated by Patrick Seidensal almost 5 years ago

  • Subject changed from mgr/dashboard: Reduce code duplication in TableActionComponent Unit Tests to mgr/dashboard: Reduce code duplication through TableActionComponent Unit Tests
Actions
Copy link
 #2

Updated by Patrick Seidensal almost 5 years ago

  • Status changed from In Progress to Fix Under Review
  • % Done changed from 0 to 90
  • Pull request ID set to 28633
Actions
Copy link
 #3

Updated by Ricardo Marques almost 5 years ago

  • Status changed from Fix Under Review to Resolved
  • Target version set to v15.0.0
Actions
Copy link
 #4

Updated by Ernesto Puerta about 3 years ago

  • Project changed from mgr to Dashboard
Actions
Copy link

Also available in: Atom PDF